NuGet.targets: fails on non-Windows machines when space in path

Topics: General
Mar 17, 2014 at 4:43 PM
Edited Mar 17, 2014 at 4:47 PM
Hi

I believe I found an issue in NuGet.targets on non-Windows machines. This command:
<NuGetCommand Condition=" '$(OS)' != 'Windows_NT' ">mono --runtime=v4.0.30319 $(NuGetExePath)</NuGetCommand>
Fails when $(NuGetExePath) has a space in a folder name. The Windows version of the property is already wrapped in quotes.

I have a PR ready, tested on OSX and Ubuntu (and Windows, but of course no change there) and I realize this is a very tiny change - but as this is my first contrib to this project, want to make sure I'm not missing any protocols before submitting.

/Rex
Mar 18, 2014 at 6:49 AM
It seems that you are still using an old version of the targets file,

https://nuget.codeplex.com/SourceControl/changeset/view/8d0139c5ed5c4127e4b61d94ac1fa0df71deba3a#src/Build/NuGet.targets

Can you test with the latest version in 2.8.1 branch? It has many known issues fixed and should work against Mono 3.2.7 without problems (restore only).
Mar 18, 2014 at 6:12 PM
This is still an issue in the branch you linked to.