1
Vote

[2.5 pre-release build] clicking 'upgrade nuget' takes me to the installed extensions tab instead of the upgrades tab

description

Not really a bug but a potential improvement :)

When trying to install a package that has the minClientVersion unsatisfied, the dialog shows a "upgrade nuget" button. Clicking the button shows the extension manager with the intent of updating the nuget extension.

expected behavior
The extensions manager shows the updates tab

actual behavior
The extensions manager shows the installed tab

comments

dotnetjunky wrote Mar 28, 2013 at 10:01 PM

We are not able to repro this bug on VS 2012. What version of VS did you see this behavior?

XavierDecoster wrote Mar 28, 2013 at 10:35 PM

I used Visual Studio Ultimate 2012, Version 11.0.51106.01 Update 1

XavierDecoster wrote Mar 28, 2013 at 10:38 PM

Made a little screencast that shows the behavior I see: http://screencast.com/t/ENNVLbjKJeJ

dotnetjunky wrote Mar 29, 2013 at 3:03 PM

Hmm, that's strange. I have the same version but it does switch to the Updates tab for me.

dotnetjunky wrote Mar 29, 2013 at 3:05 PM

Maybe you can help us debug it? :)

XavierDecoster wrote Mar 29, 2013 at 4:23 PM

The funny thing is, when debugging the experimental instance of Visual Studio, it does work as expected. However, when I install the 2.5 preview vsix in my not so experimental instance, it keeps opening the extensionmanager on the installed tab.

dotnetjunky wrote Mar 29, 2013 at 5:12 PM

You can debug your main VS instance.

XavierDecoster wrote Mar 29, 2013 at 9:28 PM

Oh, so obvious that I didn't even think of that :( Thx for the hint!
However, I guess I'll need to compile the vsix myself in debug mode as the debugger complains about optimizations and no debug information when attaching to the main VS instance with the 2.5 pre-release installed. I'll give it a shot.

XavierDecoster wrote Mar 29, 2013 at 10:06 PM

It doesn't consistently reproduce and I still haven't been able to repro this with a debugger attached.

Could this be a timing issue of some kind (looking at the code there's a dispatchertimer that tries 10x to select the updates tab). I hit the issue "sometimes" when the following conditions are met:
  • I open the package manager dialog online tab for the first time (so nothing in memcache)
  • online tab has two package sources (the preview 2.5 gallery and a local folder with the nuget package that will fail the minClientVersion requirement)
  • the preview gallery feed is loading but I don't wait for it to complete and immediately select the local pkg src (this will throw a cancellation exception which the user doesn't see unless attached with a debugger)
  • I try to install the pkg update which will fail due to the minclientversion constraint, and I hit the upgrade nuget button
  • I get the extension manager but the updates tab isn't selected, it stays on the installed tab

dotnetjunky wrote Apr 4, 2013 at 10:49 PM

If you can figure out the cause of the issue and able to come up with a fix, please send a pull request.