Issues submitting a Review for issue 829

May 20, 2011 at 12:03 AM

I have followed the guidelines at http://docs.nuget.org/docs/contribute/code-reviews yet the last step, when submitting:

typing hg postreview -g -B 829 I received an error, adding -o does not help. I don't know how to use that extension, so I guess I'm doing something wrong, anybody see anything wrong on submitting the review? I printed the error messages below.

C:\Projects\nuget\alpascualfork>hg postreview -g -B 829
postreview plugin, version 3.6.1
abort: When using the -g/--outgoingchanges flag, you must also use either the -o
 or the -O <repo> flag.

C:\Projects\nuget\alpascualfork>hg postreview -g -B 829 -o
postreview plugin, version 3.6.1
searching for changes
abort: Unable to determine parent revision for diff. If using -g/--outgoingchang
es, make sure you have some (type 'hg out'). Did you forget to commit ('hg st')?

May 20, 2011 at 12:06 AM

I have removed the -g to see if makes any difference, I think I broke something, my deepest apologies. Added a changeset yet I received an error that seems from the server.

C:\Projects\nuget\alpascualfork>hg postreview  -B 829
postreview plugin, version 3.6.1
changesets:
        1709:785a540081bf "Added support for Commas in Tags Issue 829"

reviewboard:    http://reviewboard.nupack.com/

username: alpascual
Password:
Repositories:
[1] NuGet
repository id: 1
** unknown exception encountered, please report by visiting
**  http://mercurial.selenic.com/wiki/BugTracker
** Python 2.6.6 (r266:84297, Aug 24 2010, 18:13:38) [MSC v.1500 64 bit (AMD64)]
** Mercurial Distributed SCM (version 1.8.3)
** Extensions loaded: fixfrozenexts, reviewboard
Traceback (most recent call last):
  File "hg", line 36, in <module>
  File "mercurial\dispatch.pyo", line 16, in run
  File "mercurial\dispatch.pyo", line 36, in dispatch
  File "mercurial\dispatch.pyo", line 58, in _runcatch
  File "mercurial\dispatch.pyo", line 601, in _dispatch
  File "mercurial\dispatch.pyo", line 406, in runcommand
  File "mercurial\dispatch.pyo", line 655, in _runcommand
  File "mercurial\dispatch.pyo", line 609, in checkargs
  File "mercurial\dispatch.pyo", line 598, in <lambda>
  File "mercurial\util.pyo", line 433, in check
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 68, in postreview
    send_review(ui, repo, c, parent, diff, parentdiff, opts)
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 127, in send_review
    opts)
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 214, in new_review
    raise util.Abort(_(msg))
  File "mercurial\i18n.pyo", line 39, in gettext
AttributeError: 'ReviewBoardError' object has no attribute 'split'

Developer
May 20, 2011 at 12:10 AM

Could you try a vanilla hg postreview? Does that work?

May 20, 2011 at 12:19 AM

For vanilla you mean just hg postreview -g?

 

Developer
May 20, 2011 at 1:36 AM

hg postreview with no switches

May 20, 2011 at 6:06 AM

You can try to send the review for fork

https://hg01.codeplex.com/forks/albertpascual/alpascualfork

And let me know

May 20, 2011 at 6:08 AM

pranavkm,

Still vanialla is having those issues

C:\Projects\nuget\alpascualfork>hg postreview
postreview plugin, version 3.6.1
changesets:
        1711:c781935efe12 "Added support for commas on tags 829"

reviewboard:    http://reviewboard.nupack.com/

username: alpascual
Password:
Repositories:
[1] NuGet
repository id: 1
** unknown exception encountered, please report by visiting
**  http://mercurial.selenic.com/wiki/BugTracker
** Python 2.6.6 (r266:84297, Aug 24 2010, 18:13:38) [MSC v.1500 64 bit (AMD64)]
** Mercurial Distributed SCM (version 1.8.3)
** Extensions loaded: fixfrozenexts, reviewboard
Traceback (most recent call last):
  File "hg", line 36, in <module>
  File "mercurial\dispatch.pyo", line 16, in run
  File "mercurial\dispatch.pyo", line 36, in dispatch
  File "mercurial\dispatch.pyo", line 58, in _runcatch
  File "mercurial\dispatch.pyo", line 601, in _dispatch
  File "mercurial\dispatch.pyo", line 406, in runcommand
  File "mercurial\dispatch.pyo", line 655, in _runcommand
  File "mercurial\dispatch.pyo", line 609, in checkargs
  File "mercurial\dispatch.pyo", line 598, in <lambda>
  File "mercurial\util.pyo", line 433, in check
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 68, in postreview
    send_review(ui, repo, c, parent, diff, parentdiff, opts)
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 127, in send_review
    opts)
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 214, in new_review
    raise util.Abort(_(msg))
  File "mercurial\i18n.pyo", line 39, in gettext
AttributeError: 'ReviewBoardError' object has no attribute 'split'

C:\Projects\nuget\alpascualfork>

Developer
May 20, 2011 at 6:09 AM

Try hg postreview -l

Developer
May 20, 2011 at 6:13 AM

Actually the problem is that you need to merge with main first, do the following:

hg pull https://hg01.codeplex.com/nuget
hg up default
hg merge c781935efe12

Commit the merged changeset and run hg postreview again.

Developer
May 20, 2011 at 6:16 AM

Also why does your fork seem to have 4 similar changes? Are those on purpose?

May 20, 2011 at 6:27 AM

Crap already on the plane, I'll try it in the morning.
I have save the file and push the latest, the last one was tested and working fine, the previous are not good. Should just keep the latest correct?

Cheers
Al
Sent from my iPhone 4
Please excuse terseness and typos.

On May 19, 2011, at 10:16 PM, "dfowler" <notifications@codeplex.com> wrote:

From: dfowler

Also why does your fork seem to have 4 similar changes? Are those on purpose?

Developer
May 20, 2011 at 6:51 AM

Doesn't really matter as long as the end result is good.

May 20, 2011 at 7:52 AM
Fantastic, thanks for your help, I'll try the merge in the morning and let you know. If that works, the docs should also show how to do the merge before submitting for review I think.

Thanks again
>
May 20, 2011 at 3:49 PM

Just did that with the same result :-(

C:\Projects\nuget\alpascualfork>hg pull https://hg01.codeplex.com/nuget
pulling from https://hg01.codeplex.com/nuget
searching for changes
adding changesets
adding manifests
adding file changes
added 17 changesets with 43 changes to 20 files (+1 heads)
(run 'hg heads' to see heads, 'hg merge' to merge)

C:\Projects\nuget\alpascualfork>hg up default
20 files updated, 0 files merged, 0 files removed, 0 files unresolved

C:\Projects\nuget\alpascualfork>hg merge c781935efe12
merging src/CommandLine/Commands/SpecCommand.cs
1 files updated, 1 files merged, 0 files removed, 0 files unresolved
(branch merge, don't forget to commit)

C:\Projects\nuget\alpascualfork>hg commit -m "merge with main with 829"
abort: no username supplied (see "hg help config")

C:\Projects\nuget\alpascualfork>hg commit -m "merge with main with 829" -u alber
tpascual

C:\Projects\nuget\alpascualfork>hg postreview
postreview plugin, version 3.6.1
changesets:
        1729:514cbb28ffab "merge with main with 829"

reviewboard:    http://reviewboard.nupack.com/

username: alpascual
Password:
Repositories:
[1] NuGet
repository id: 1
** unknown exception encountered, please report by visiting
**  http://mercurial.selenic.com/wiki/BugTracker
** Python 2.6.6 (r266:84297, Aug 24 2010, 18:13:38) [MSC v.1500 64 bit (AMD64)]
** Mercurial Distributed SCM (version 1.8.3)
** Extensions loaded: fixfrozenexts, reviewboard
Traceback (most recent call last):
  File "hg", line 36, in <module>
  File "mercurial\dispatch.pyo", line 16, in run
  File "mercurial\dispatch.pyo", line 36, in dispatch
  File "mercurial\dispatch.pyo", line 58, in _runcatch
  File "mercurial\dispatch.pyo", line 601, in _dispatch
  File "mercurial\dispatch.pyo", line 406, in runcommand
  File "mercurial\dispatch.pyo", line 655, in _runcommand
  File "mercurial\dispatch.pyo", line 609, in checkargs
  File "mercurial\dispatch.pyo", line 598, in <lambda>
  File "mercurial\util.pyo", line 433, in check
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 68, in postreview
    send_review(ui, repo, c, parent, diff, parentdiff, opts)
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 127, in send_review
    opts)
  File "C:\Projects\nuget\review\mercurial-reviewboard\mercurial_reviewboard\__i
nit__.py", line 214, in new_review
    raise util.Abort(_(msg))
  File "mercurial\i18n.pyo", line 39, in gettext
AttributeError: 'ReviewBoardError' object has no attribute 'split'

C:\Projects\nuget\alpascualfork>

May 20, 2011 at 7:13 PM

Is there any other way I can submit for review?

May 26, 2011 at 10:27 PM

FWIW, I'm getting the same error. I set all of this up today, so should be all the latest versions of tooling.

[snip]
AttributeError: 'ReviewBoardError' object has no attribute 'split'

Coordinator
May 26, 2011 at 10:28 PM

If it’s a relatively small change, send a pull request and we’ll use the CodePlex limited code review feature. If it’s a big change, one of our devs can help you get ReviewBoard setup.

Phil

May 26, 2011 at 11:02 PM
Edited May 26, 2011 at 11:04 PM

Posted an issue to their group: http://code.google.com/p/reviewboard/issues/detail?id=2114

Haacked/dfowler, What version are y'all using? Both albert and I have postreview plugin, version 3.6.1

May 27, 2011 at 3:11 AM

Whoops, I'm a dolt. Wrong group.

Let's try again: http://code.google.com/p/mercurial-reviewboard/issues/detail?id=29

May 27, 2011 at 2:57 PM

I had a feeling when I posted the last time... Posted to the wrong group _again_. But, I guess this is moot since I see y'all are punting reviewboard?